Re: gitweb.cgi and git instaweb

Subsystems: the rest

3 messages, 3 authors, 2016-08-11 · open the first message on its own page

Re: gitweb.cgi and git instaweb

From: Junio C Hamano <hidden>
Date: 2016-08-11 20:31:31

"Aneesh Kumar K.V" [off-list ref] writes:

quoted hunk

Aneesh Kumar K.V wrote:

quoted

I am getting errors as below with git instaweb.


kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ git instaweb
2006-10-27 00:12:56: (log.c.75) server started
kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ [Fri Oct 27
00:12:57 2006] gitweb.cgi: "our" variable $stylesheet masks earlier
declaration in same scope at

The attached patch should fix it.

-aneesh

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index ba7a42a..1962c76 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl

@@ -55,8 +55,6 @@ our $stylesheet;
 # default is not to define style sheet, but it can be overwritten later
 undef $stylesheet;
 
-# URI of default stylesheet
-our $stylesheet = "++GITWEB_CSS++";
 # URI of GIT logo (72x27 size)
 our $logo = "++GITWEB_LOGO++";
 # URI of GIT favicon, assumed to be image/png type

Removing the extraneous undef would also be a good idea,
wouldn't it?

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index aceaeb7..7999b1a 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl

@@ -51,12 +51,10 @@ our $site_footer = "++GITWEB_SITE_FOOTER
 
 # URI of stylesheets
 our @stylesheets = ("++GITWEB_CSS++");
-our $stylesheet;
-# default is not to define style sheet, but it can be overwritten later
-undef $stylesheet;
-
 # URI of default stylesheet
-our $stylesheet = "++GITWEB_CSS++";
+# default is not to define style sheet, but it can be overwritten later.
+our $stylesheet = undef;
+
 # URI of GIT logo (72x27 size)
 our $logo = "++GITWEB_LOGO++";
 # URI of GIT favicon, assumed to be image/png type

Re: gitweb.cgi and git instaweb

From: Petr Baudis <hidden>
Date: 2016-08-11 19:25:08

Dear diary, on Fri, Oct 27, 2006 at 09:05:20AM CEST, I got a letter
where Junio C Hamano [off-list ref] said that...

Removing the extraneous undef would also be a good idea,
wouldn't it?

25746   F Oct 26 Petr Baudis     ( 0.9K) [PATCH] gitweb: Fix up bogus $stylesheet declarations

?

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1

Re: gitweb.cgi and git instaweb

From: Aneesh Kumar K.V <hidden>
Date: 2016-08-11 20:17:30

Junio C Hamano wrote:

quoted hunk

"Aneesh Kumar K.V" [off-list ref] writes:

quoted

Aneesh Kumar K.V wrote:

quoted

I am getting errors as below with git instaweb.


kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ git instaweb
2006-10-27 00:12:56: (log.c.75) server started
kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ [Fri Oct 27
00:12:57 2006] gitweb.cgi: "our" variable $stylesheet masks earlier
declaration in same scope at

The attached patch should fix it.

-aneesh

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index ba7a42a..1962c76 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl

@@ -55,8 +55,6 @@ our $stylesheet;
 # default is not to define style sheet, but it can be overwritten later
 undef $stylesheet;
 
-# URI of default stylesheet
-our $stylesheet = "++GITWEB_CSS++";
 # URI of GIT logo (72x27 size)
 our $logo = "++GITWEB_LOGO++";
 # URI of GIT favicon, assumed to be image/png type

Removing the extraneous undef would also be a good idea,
wouldn't it?

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index aceaeb7..7999b1a 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl

@@ -51,12 +51,10 @@ our $site_footer = "++GITWEB_SITE_FOOTER
 
 # URI of stylesheets
 our @stylesheets = ("++GITWEB_CSS++");
-our $stylesheet;
-# default is not to define style sheet, but it can be overwritten later
-undef $stylesheet;
-
 # URI of default stylesheet
-our $stylesheet = "++GITWEB_CSS++";
+# default is not to define style sheet, but it can be overwritten later.
+our $stylesheet = undef;
+
 # URI of GIT logo (72x27 size)
 our $logo = "++GITWEB_LOGO++";
 # URI of GIT favicon, assumed to be image/png type

ACK

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help