# \[PATCH\] gitweb: Add an option to href() to return full URL

- Subsystems: THE REST
- Maintainers: Linus Torvalds
- List: git
- 1 message, 1 author
- Page: https://ratatoskr.run/git/2016/08/7691867/t

## \[PATCH\] gitweb: Add an option to href() to return full URL

- From: Jakub Narebski \<hidden\>
- Date: 2016-08-11 20:29:13 
- Message: https://ratatoskr.run/git/2016/08/7691867.md

```text
href() subroutine by default generates absolute URL (generated using
CGI::url(-absolute=>1), and saved in $my_uri) using $my_uri as base;
add an option to generate full URL using $my_url as base.

New feature usage: href(..., -full=>1)

Signed-off-by: Jakub Narebski <redacted>
---
This is in preparation for git_rss cleanup (to use href), and further
per-branch (per-head) RSS feeds.

 gitweb/gitweb.perl |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 8313517..f3fe4bf 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -459,7 +459,8 @@ exit;
 
 sub href(%) {
 	my %params = @_;
-	my $href = $my_uri;
+	# default is to use -absolute url() i.e. $my_uri
+	my $href = $params{-full} ? $my_url : $my_uri;
 
 	# XXX: Warning: If you touch this, check the search form for updating,
 	# too.
-- 
1.4.3.4
```