Re: [PATCH 3/5] get_shallow_commits: Avoid memory leak if a commit has been reached already.

Johannes Schindelin [off-list ref] writes:

On Sat, 25 Nov 2006, Anand Kumria wrote:

quoted

Any reason you didn't do:

if (!commit->util)
	commit->util = xcalloc(1, sizeof(int));

xmalloc() does not initialize the memory. Therefore, it is usually 
preferred if you initialize the memory yourself. In this case, the memory 
is initialized to 0, even if it is not allocated.

It may be a minor performance issue, but it is a good habit to use xcalloc 
only if it is needed.

I think you could pretend the commit->util field to be of some
kind of int and avoid the allocation altogether ;-).

Hi,

On Sat, 25 Nov 2006, Junio C Hamano wrote:

I think you could pretend the commit->util field to be of some kind of 
int and avoid the allocation altogether ;-).

I actually thought about that, and found it too dangerous. But of course, 
since we need at least a 32-bit architecture, chances are very high that a 
pointer is castable to an int.

Ciao,
Dscho