Re: [PATCH] index-pack usage of mmap() is unacceptably slower on many OSes other than Linux

3 messages, 3 authors, 2016-08-11 · open the first message on its own page

Re: [PATCH] index-pack usage of mmap() is unacceptably slower on many OSes other than Linux

From: Junio C Hamano <hidden>
Date: 2016-08-11 20:11:39

Jeff Garzik [off-list ref] writes:
If you are going to do this, you have to audit -every- file, to make
sure git-compat-util.h is -always- the first header.
Will do.

Re: [PATCH] index-pack usage of mmap() is unacceptably slower on many OSes other than Linux

From: Jeff Garzik <hidden>
Date: 2016-08-11 20:11:24

Linus Torvalds wrote:
On Tue, 19 Dec 2006, Junio C Hamano wrote:
quoted
Jeff Garzik [off-list ref] writes:
quoted
If you are going to do this, you have to audit -every- file, to make
sure git-compat-util.h is -always- the first header.
Will do.
Well, since any cases where it isn't (and where we'd care) will  show up 
as just a compiler warning, I doubt we really even need to. We can fix 
things up as they get reported too..
I wouldn't assume that is always the case.  Mostly true, I would 
suppose.  But some of those defines turn on and off 64-bit file 
size/offset gadgets for example.

	Jeff

Re: [PATCH] index-pack usage of mmap() is unacceptably slower on many OSes other than Linux

From: Linus Torvalds <torvalds@osdl.org>
Date: 2016-08-11 20:45:20


On Tue, 19 Dec 2006, Junio C Hamano wrote:
Jeff Garzik [off-list ref] writes:
quoted
If you are going to do this, you have to audit -every- file, to make
sure git-compat-util.h is -always- the first header.
Will do.
Well, since any cases where it isn't (and where we'd care) will  show up 
as just a compiler warning, I doubt we really even need to. We can fix 
things up as they get reported too..
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help