Re: [PATCH] gitweb: Remove extra "/" in path names for git_get_project_list

"Aneesh Kumar K.V" [off-list ref] writes:

Without this change we get a wrong $pfxlen value and the check_export_ok()
checks with with a wrong directory name. Without this patch the below
$projects_list fails with gitweb

$projects_list = "/tmp/a/b/";

Signed-off-by: Aneesh Kumar K.V <redacted>

Hmph.  Doesn't this break $projects_list = "/", I wonder?

+		# remove the trailing "/"
+		$dir =~ s!/+$!!;

Junio C Hamano wrote:

"Aneesh Kumar K.V" [off-list ref] writes:

quoted

Without this change we get a wrong $pfxlen value and the check_export_ok()
checks with with a wrong directory name. Without this patch the below
$projects_list fails with gitweb

$projects_list = "/tmp/a/b/";

Signed-off-by: Aneesh Kumar K.V <redacted>

Hmph.  Doesn't this break $projects_list = "/", I wonder?

quoted

+            # remove the trailing "/"
+            $dir =~ s!/+$!!;

So perhaps

        $dir =~ s!(?<=[^/])/+$!!;

(zero-width positive look-behind assertion).
-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git