Re: [PATCH] git-diff: don't add trailing blanks (i.e., do what GNU diff -u now does)

From: Junio C Hamano <hidden>
Date: 2016-08-11 19:38:15

Linus Torvalds [off-list ref] writes:

On Sun, 17 Dec 2006, Jim Meyering wrote:

quoted

You may recall that GNU diff -u changed recently so that it no
longer outputs any trailing space unless the input data has it.

I still consider that to be a bug in GNU "diff -u".

We work around that bug when applying patches, but I don't think we should 
replicate it.

Me neither.

From: Jakub Narebski <hidden>
Date: 2016-08-11 19:36:05

Junio C Hamano wrote:

Linus Torvalds [off-list ref] writes:

quoted

On Sun, 17 Dec 2006, Jim Meyering wrote:

quoted

You may recall that GNU diff -u changed recently so that it no
longer outputs any trailing space unless the input data has it.

I still consider that to be a bug in GNU "diff -u".

We work around that bug when applying patches, but I don't think we should 
replicate it.

Me neither.

Perhaps with --gnu-diff-compatibility then? 

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git

From: Johannes Schindelin <hidden>
Date: 2016-08-11 20:11:44

Hi,

On Sun, 17 Dec 2006, Jakub Narebski wrote:

Junio C Hamano wrote:

quoted

Linus Torvalds [off-list ref] writes:

quoted

On Sun, 17 Dec 2006, Jim Meyering wrote:

quoted

You may recall that GNU diff -u changed recently so that it no
longer outputs any trailing space unless the input data has it.

I still consider that to be a bug in GNU "diff -u".

We work around that bug when applying patches, but I don't think we should 
replicate it.

Me neither.

Perhaps with --gnu-diff-compatibility then?

Rather --braindead-gnu-bug-compatibility.

Ciao,
Dscho