Re: [PATCH 1/4] git-svn: let libsvn_ls_fullurl return properties too

2 messages, 2 authors, 2016-08-11 · open the first message on its own page

Re: [PATCH 1/4] git-svn: let libsvn_ls_fullurl return properties too

From: Junio C Hamano <hidden>
Date: 2016-08-11 19:35:01

Thanks.

Please CC people who are primarily working on the part of the
system you are improving.  In the case of git-svn that would be
Eric Wong.

As I almost never touch git-svn myself, I'll queue these four
changes in 'pu' while waiting Ack from Eric on them.


Re: [PATCH 1/4] git-svn: let libsvn_ls_fullurl return properties too

From: Eric Wong <hidden>
Date: 2016-08-11 20:44:33

Junio C Hamano [off-list ref] wrote:
Thanks.

Please CC people who are primarily working on the part of the
system you are improving.  In the case of git-svn that would be
Eric Wong.
Yes, CCs regarding git-svn would be much appreciated, thanks.
As I almost never touch git-svn myself, I'll queue these four
changes in 'pu' while waiting Ack from Eric on them.
Ack on what the patches do, but not as-is.

Please fix the coding style so that it's consistent with the rest of
git-svn:

a) indentation is done with hard tabs
b) no spaces around parentheses: "if ($foo) {" vs "if ( $foo ) {"

Also, adding tests would be helpful in helping me maintain it (I'm not
a regular svk user, so I don't want to break anything you've done down
the line).

Thanks.

-- 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help