Re: [PATCH 1/2] move Git.pm build instructions into perl/Makefile

"Alex Riesen" [off-list ref] writes:

Signed-off-by: Alex Riesen <redacted>

---

This is the first patch, just rebased upon current master.
The ActiveState-related parts follow

Huh?

Ah, attachment that is not inline.

diff --git a/perl/.gitignore b/perl/.gitignore
index e990cae..98b2477 100644
--- a/perl/.gitignore
+++ b/perl/.gitignore

@@ -1,4 +1,5 @@
-Makefile
+perl.mak
+perl.mak.old
 blib
 blibdirs
 pm_to_blib

This, and perl/Makefile not cleaning perl.mak.old, are wrong.
"make && make clean" after a fresh checkout should leave the
working tree the same state is it were.

On 12/3/06, Junio C Hamano [off-list ref] wrote:

How is this wrong, and the previous (for when there weren't
Makefile at all) Makefile-in-.gitignore is not?
These are generated files, what do you want to preserve them for?

"make && make clean" after a fresh checkout should leave the
working tree the same state is it were.

oh, right. Missed it (never seen it generated, BTW. Just took
from Pasky's code that it happens).

Updated patch attached.