Re: [PATCH v4 1/8] status: rename long-format print routines

2 messages, 2 authors, 2016-08-04 · open the first message on its own page

Re: [PATCH v4 1/8] status: rename long-format print routines

From: Junio C Hamano <hidden>
Date: 2016-08-03 21:35:22

Jeff Hostetler [off-list ref] writes:
From: Jeff Hostetler <redacted>

Renamed the various wt_status_print*() routines to be
wt_longstatus_print*() to make it clear that these
routines are only concerned with the normal/long
status output.
We tend to write "Rename the various...", as if you the patch author
is giving an order to "become so" to the codebase, or "make it so"
to the maintainer.

Other than that, this step looks straight-forward, and I agree with
the hope that this will reduce confusion that readers may have while
reading a future version of this code.
This will hopefully reduce confusion as other status
formats are added in the future.

Signed-off-by: Jeff Hostetler <redacted>
Signed-off-by: Jeff Hostetler <redacted>
Hmm, are these physically the same people?  If so, which one do you
want to be known as?

Thanks.

Re: [PATCH v4 1/8] status: rename long-format print routines

From: Jeff Hostetler <hidden>
Date: 2016-08-04 12:33:18


On 08/03/2016 05:28 PM, Junio C Hamano wrote:
quoted
Signed-off-by: Jeff Hostetler <redacted>
Signed-off-by: Jeff Hostetler <redacted>
Hmm, are these physically the same people?  If so, which one do you
want to be known as?
Yes, these are both my addresses.  Still struggling a little
with some SMTP issues.  Please use the jeffhost@microsoft.com address.

Thanks.
Jeff

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help