Re: [RFC/PATCH v11 09/13] bisect--helper: `bisect_write` shell function in C

2 messages, 2 authors, 2016-08-03 · open the first message on its own page

Re: [RFC/PATCH v11 09/13] bisect--helper: `bisect_write` shell function in C

From: Junio C Hamano <hidden>
Date: 2016-08-02 22:30:22

Junio C Hamano [off-list ref] writes:
Pranit Bauva [off-list ref] writes:
quoted
Reimplement the `bisect_write` shell function in C and add a
`bisect-write` subcommand to `git bisect--helper` to call it from
git-bisect.sh
Up to around this step we've seen these patches well enough and I
think with another reroll or two, they are in good enough shape to
be split out and frozen for 'next'.  We may not be there quite yet,
but I think we are getting pretty close.

Thanks.
By the way, this series applied as a whole seems to break t6030.

Re: [RFC/PATCH v11 09/13] bisect--helper: `bisect_write` shell function in C

From: Pranit Bauva <hidden>
Date: 2016-08-03 20:52:10

Hey Junio,

On Wed, Aug 3, 2016 at 3:47 AM, Junio C Hamano [off-list ref] wrote:
Junio C Hamano [off-list ref] writes:
quoted
Pranit Bauva [off-list ref] writes:
quoted
Reimplement the `bisect_write` shell function in C and add a
`bisect-write` subcommand to `git bisect--helper` to call it from
git-bisect.sh
Up to around this step we've seen these patches well enough and I
think with another reroll or two, they are in good enough shape to
be split out and frozen for 'next'.  We may not be there quite yet,
but I think we are getting pretty close.

Thanks.
By the way, this series applied as a whole seems to break t6030.
This is only because of argument handling problem. I seemed to have
mentioned it in patch 13/13 and also gave the output of the tests.

Regards,
Pranit Bauva
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help