Re: [PATCH] git-sh-setup.sh: fix missing double quotes variables

LE Manh Cuong [off-list ref] writes:

It's not only people shooting their foot, but also from malicious user.
Given that `curl url | sudo sh/bash` is often found in many instructions,
an end user may not be noticed about the environment variable injection
from their side.

IMHO, it's better if  git can protect the end users in this situation.

Huh?  For those who run `curl url | sudo sh`, I do not think the
incoming script setting and exporting LV to an arbitrary value and
runing Git is not the top thing they need worry about.

While I think enclosing the string in dq is an improvement (as I
said already), I still do think your use of the v-word is making a
mountain out of an anthill.

While I think enclosing the string in dq is an improvement (as I
said already), I still do think your use of the v-word is making a
mountain out of an anthill.

Well, sorry if that word is annoyed.

So, is this patch fine or I must re-phrase the title?