[bug] assertion in 2.8.4 triggering on old-ish worktree

Hi All,

I have the git-sh-prompt configured in my .bashrc today I visited an
old worktree that I haven't really touched in a few years (sorry can't
remember the git version I was using back then). I received the
following output when changing to the directory

git: pathspec.c:317: prefix_pathspec: Assertion `item->nowildcard_len
<= item->len && item->prefix <= item->len' failed.

I assume it's one of the git invocations in git-sh-prompt that's
hitting the assertion. Any thoughts on what might be triggering it?
Any debug I can gather?

On Thu, Jun 16, 2016 at 4:59 PM, Chris Packham [off-list ref] wrote:

Hi All,

I have the git-sh-prompt configured in my .bashrc today I visited an
old worktree that I haven't really touched in a few years (sorry can't
remember the git version I was using back then). I received the
following output when changing to the directory

git: pathspec.c:317: prefix_pathspec: Assertion `item->nowildcard_len
<= item->len && item->prefix <= item->len' failed.

I assume it's one of the git invocations in git-sh-prompt that's
hitting the assertion. Any thoughts on what might be triggering it?
Any debug I can gather?

A bit more info. The directory in question is a uninitialised
submodule. It doesn't trigger in the root of the parent project.

On Wed, Jun 15, 2016 at 10:02 PM, Chris Packham [off-list ref] wrote:

On Thu, Jun 16, 2016 at 4:59 PM, Chris Packham [off-list ref] wrote:

quoted

Hi All,

I have the git-sh-prompt configured in my .bashrc today I visited an
old worktree that I haven't really touched in a few years (sorry can't
remember the git version I was using back then). I received the
following output when changing to the directory

git: pathspec.c:317: prefix_pathspec: Assertion `item->nowildcard_len
<= item->len && item->prefix <= item->len' failed.

I assume it's one of the git invocations in git-sh-prompt that's
hitting the assertion. Any thoughts on what might be triggering it?
Any debug I can gather?

The first step would be to identify which git command is actually causing it.
Can you take your  git-sh-prompt and run it step by step to figure out what
command is failing?

The next step after that would be to see if we can reproduce it in a reduced
test case (with no real data) so we can add a regression test and a fix for it.

A bit more info. The directory in question is a uninitialised
submodule. It doesn't trigger in the root of the parent project.

so it's a

    cd submodule
    git <command>

that is failing?

Thanks,
Stefan

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

On do, 2016-06-16 at 17:02 +1200, Chris Packham wrote:

On Thu, Jun 16, 2016 at 4:59 PM, Chris Packham <judge.packham@gmail.c
om> wrote:

quoted

Hi All,

I have the git-sh-prompt configured in my .bashrc today I visited
an
old worktree that I haven't really touched in a few years (sorry
can't
remember the git version I was using back then). I received the
following output when changing to the directory

git: pathspec.c:317: prefix_pathspec: Assertion `item-

quoted

nowildcard_len

<= item->len && item->prefix <= item->len' failed.

I assume it's one of the git invocations in git-sh-prompt that's
hitting the assertion. Any thoughts on what might be triggering it?
Any debug I can gather?

A bit more info. The directory in question is a uninitialised
submodule. It doesn't trigger in the root of the parent project.

That very much smells like a class of bugs we've seen before, with git
getting confused around submodules. See also for example

https://www.mail-archive.com/git@vger.kernel.org/msg68447.html

I don't think an accepted fix exists yet.

D.

On Thu, Jun 16, 2016 at 9:55 AM, Dennis Kaarsemaker
[off-list ref] wrote:

On do, 2016-06-16 at 17:02 +1200, Chris Packham wrote:

quoted

On Thu, Jun 16, 2016 at 4:59 PM, Chris Packham <judge.packham@gmail.c
om> wrote:

quoted

Hi All,

I have the git-sh-prompt configured in my .bashrc today I visited
an
old worktree that I haven't really touched in a few years (sorry
can't
remember the git version I was using back then). I received the
following output when changing to the directory

git: pathspec.c:317: prefix_pathspec: Assertion `item-

quoted

nowildcard_len

<= item->len && item->prefix <= item->len' failed.

I assume it's one of the git invocations in git-sh-prompt that's
hitting the assertion. Any thoughts on what might be triggering it?
Any debug I can gather?

A bit more info. The directory in question is a uninitialised
submodule. It doesn't trigger in the root of the parent project.

That very much smells like a class of bugs we've seen before, with git
getting confused around submodules. See also for example

https://www.mail-archive.com/git@vger.kernel.org/msg68447.html

I don't think an accepted fix exists yet.

Thanks for pointing me at that report. I was not aware of this "class of bugs",
I'll see if I can fix it.

Thanks,
Stefan

D.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html