[PATCH] refs: mark the file-local vtable symbols as static
From: Ramsay Jones <hidden>
Date: 2016-06-16 02:19:48
Subsystem:
the rest · Maintainer:
Linus Torvalds
Signed-off-by: Ramsay Jones <redacted> --- Hi Michael, Junio, I would normally ask you to squash this into the relevant patch when you next re-roll your 'mh/ref-iterators' branch, but this has already been merged into next. (I normally have a bit more time ... sorry!). Perhaps, after the release, when the next branch is re-wound/re-built, this could be squashed into your branch then. Anyway, after applying this patch, the following symbols are still 'public but unused': > refs/files-backend.o - files_reflog_iterator_begin > refs/iterator.o - is_empty_ref_iterator > refs/iterator.o - merge_ref_iterator_begin These all look (potentially) useful for the implementation of additional 'ref-iter' types and look to be part of the _internal_ iterator API - so they should not be marked static. Can you just confirm my interpretation. Thanks. ATB, Ramsay Jones refs/files-backend.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/refs/files-backend.c b/refs/files-backend.c
index a006a65..6213891 100644
--- a/refs/files-backend.c
+++ b/refs/files-backend.c@@ -711,7 +711,7 @@ static int cache_ref_iterator_abort(struct ref_iterator *ref_iterator) return ITER_DONE; } -struct ref_iterator_vtable cache_ref_iterator_vtable = { +static struct ref_iterator_vtable cache_ref_iterator_vtable = { cache_ref_iterator_advance, cache_ref_iterator_peel, cache_ref_iterator_abort
@@ -1933,7 +1933,7 @@ static int files_ref_iterator_abort(struct ref_iterator *ref_iterator) return ok; } -struct ref_iterator_vtable files_ref_iterator_vtable = { +static struct ref_iterator_vtable files_ref_iterator_vtable = { files_ref_iterator_advance, files_ref_iterator_peel, files_ref_iterator_abort
@@ -3354,7 +3354,7 @@ static int files_reflog_iterator_abort(struct ref_iterator *ref_iterator) return ok; } -struct ref_iterator_vtable files_reflog_iterator_vtable = { +static struct ref_iterator_vtable files_reflog_iterator_vtable = { files_reflog_iterator_advance, files_reflog_iterator_peel, files_reflog_iterator_abort
--
2.8.0