Re: [Bug?] log -p -W showing the whole file for a patch that adds to the end?

René Scharfe [off-list ref] writes:

Am 24.05.2016 um 20:16 schrieb Junio C Hamano:

quoted

René Scharfe [off-list ref] writes:

quoted

   diff: factor out match_func_rec()
   diff: handle appended chunks better with -W
   diff: ignore empty lines before added functions with -W
   diff: don't include common trailing empty lines with -W
   grep: don't extend context to trailing empty lines with -W

  grep.c        | 28 ++++++++++++++++++++++++--
  xdiff/xemit.c | 63 ++++++++++++++++++++++++++++++++++++++++++++++++++++-------
  2 files changed, 82 insertions(+), 9 deletions(-)

quoted

It is curious that this much behaviour change does not need any
changes in the test scripts.  We do not have sufficient coverage,
perhaps?

Well, -W is not tested at all.  I'll include some in the next round.
No need to hurry, it's too late to land in 2.9.0 anyway.

True.

I'd say that these patches are fine as they are, and follow-up patch
for adding -W tests (instead of rerolling them) is sufficient,
though.

Am 26.05.2016 um 19:05 schrieb Junio C Hamano:

I'd say that these patches are fine as they are, and follow-up patch
for adding -W tests (instead of rerolling them) is sufficient,
though.

Patch 3 needs two small updates to address the char signedness issue 
found by Ramsay and to get rid of an unused function parameter, and 
patch 4 needs a small change as a result of the latter as well. 
Shouldn't be long before tests are done..

René