# Re: \[PATCH v2 3/5\] t1500: avoid changing working directory outside of tests

- From: Eric Sunshine \<hidden\>
- Date: 2016-06-16 02:19:26 
- List: git
- Page: https://ratatoskr.run/git/2016/06/7681052
- Thread: https://ratatoskr.run/git/2016/06/7681045/t.md

```text
On Tue, May 17, 2016 at 7:06 PM, SZEDER Gábor [ref] wrote:
> Quoting Junio C Hamano [ref]:
>> Jeff King [ref] writes:
>>> On Tue, May 17, 2016 at 04:48:33PM -0400, Eric Sunshine wrote:
>>>> On Tue, May 17, 2016 at 4:37 PM, Junio C Hamano [ref]
>>>> wrote:
>>>>> Eric Sunshine [ref] writes:
>>>>>> +                     git ${dir:+-C "$dir"} rev-parse --$o >actual &&
>>>>>
>>>>> This is kosher POSIX, but I vaguely recall some shells had trouble
>>>>> with the SP between -C and "$dir" in the past.  Let's see if anybody
>>>>> screams; hopefully I am misremembering or buggy shells died out.
>>>>
>>>> I also am bothered by a vague recollection of some issue (possibly
>>>> involving the internal space and lack of quotes around the entire
>>>> ${...}), but couldn't remember nor find a reference to the specific
>>>> details. Perhaps someone reading the patch has a better memory than I.
>>>
>>> Probably:
>>>  http://thread.gmane.org/gmane.comp.version-control.git/265094
>
> And ea10b60c910e (Work around ash "alternate value" expansion bug,
> 2009-04-18) as well.
>
>    http://thread.gmane.org/gmane.comp.version-control.git/116816

Thanks for the additional link. I have v3 ready to roll and will send
it out within the next day if no more actionable review comments
arrive.
```