# Re: \[PATCH v2 3/5\] t1500: avoid changing working directory outside of tests

- From: Junio C Hamano \<hidden\>
- Date: 2016-06-16 02:19:26 
- List: git
- Page: https://ratatoskr.run/git/2016/06/7681035
- Thread: https://ratatoskr.run/git/2016/06/7681035/t.md

```text
Eric Sunshine [ref] writes:

> +			git ${dir:+-C "$dir"} rev-parse --$o >actual &&

This is kosher POSIX, but I vaguely recall some shells had trouble
with the SP between -C and "$dir" in the past.  Let's see if anybody
screams; hopefully I am misremembering or buggy shells died out.

Other than that, the entire series makes the script easier to grok.
Thanks.
```