Re: [PATCH v5 2/9] connect: only match the host with core.gitProxy

Mike Hommey [off-list ref] writes:

Currently, core.gitProxy doesn't actually match purely on domain names
as documented: it also matches ports.
...
This per-port behavior seems like an oversight rather than a deliberate
choice, so, make git://kernel.org:port/path call the gitProxy script in

Hmph.  The fact that hostandport, not just host after stripping
possible ":port" part, is passed to the function smells like a
deliberate design to allow people to use different proxy for
different port, so I am not sure everybody agrees with your "seems
like an oversight".

Don't existing users depend on the behaviour?  Isn't the change
robbing Peter to pay Paul?

On Mon, May 16, 2016 at 03:30:01PM -0700, Junio C Hamano wrote:

Mike Hommey [off-list ref] writes:

quoted

Currently, core.gitProxy doesn't actually match purely on domain names
as documented: it also matches ports.
...
This per-port behavior seems like an oversight rather than a deliberate
choice, so, make git://kernel.org:port/path call the gitProxy script in

Hmph.  The fact that hostandport, not just host after stripping
possible ":port" part, is passed to the function smells like a
deliberate design to allow people to use different proxy for
different port, so I am not sure everybody agrees with your "seems
like an oversight".

Don't existing users depend on the behaviour?  Isn't the change
robbing Peter to pay Paul?

The gitProxy script gets the port passed. Why would you need different
scripts for different ports if the port is passed as an argument? Also,
if it's deliberate, it's widely undocumented.

Mike