# Re: \[PATCH v9 2/6\] convert.c: stream and early out

- From: Torsten Bögershausen \<hidden\>
- Date: 2016-06-16 02:19:18 
- List: git
- Page: https://ratatoskr.run/git/2016/06/7680348
- Thread: https://ratatoskr.run/git/2016/06/7680171/t.md

```text
On 09.05.16 22:29, Junio C Hamano wrote:
> tboegi@web.de writes:
> 
>> +		if (stats->stat_bits & earlyout)
>> +			break; /* We found what we have been searching for */
> 
> Are we sure if our callers are only interested in just one bit at a
> time?  Otherwise, if we want to ensure all of the given bits are
> set,
> 
> 	if ((stats->stat_bits & earlyout) == earlyout)
>         	break;
> 
> would be necessary.  Otherwise, the "only one bit" assumption on the
> "earlyout" parameter somehow needs to be documented in the code.
Thanks for pointing that out.
I have changed the code a couple of times, forth and back.
I want to re-roll the series anyway (probably in the next weeks),
so something like "search_only_flags" may be a better name.
```