Re: [PATCH] pathspec: remove check_path_for_gitlink

2 messages, 2 authors, 2016-06-16 · open the first message on its own page

Re: [PATCH] pathspec: remove check_path_for_gitlink

From: Junio C Hamano <hidden>
Date: 2016-06-16 02:19:12

Stefan Beller [off-list ref] writes:
quoted hunk
`check_path_for_gitlink` was introduced in 9d67b61f739a (2013-01-06,
add.c: extract check_path_for_gitlink() from treat_gitlinks() for reuse)
but the implementation was removed in 5a76aff1a6 (2013-07-14, add:
convert to use parse_pathspec).

Remove the declaration from the header as well.

Signed-off-by: Stefan Beller <redacted>
---
 pathspec.h | 1 -
 1 file changed, 1 deletion(-)
diff --git a/pathspec.h b/pathspec.h
index 0c11262..b596aed 100644
--- a/pathspec.h
+++ b/pathspec.h
@@ -96,7 +96,6 @@ static inline int ps_strcmp(const struct pathspec_item *item,
 
 extern char *find_pathspecs_matching_against_index(const struct pathspec *pathspec);
 extern void add_pathspec_matches_against_index(const struct pathspec *pathspec, char *seen);
-extern const char *check_path_for_gitlink(const char *path);
 extern void die_if_path_beyond_symlink(const char *path, const char *prefix);
 
 #endif /* PATHSPEC_H */
Interesting.

I wonder if the patches mentioned have something to do with the "git
add deep/in/the/tree" that fails to notice deep/in/ is an unrelated
repository in some way?

Re: [PATCH] pathspec: remove check_path_for_gitlink

From: Stefan Beller <hidden>
Date: 2016-06-16 02:19:12

On Thu, May 5, 2016 at 4:09 PM, Junio C Hamano [off-list ref] wrote:
Stefan Beller [off-list ref] writes:
quoted
`check_path_for_gitlink` was introduced in 9d67b61f739a (2013-01-06,
add.c: extract check_path_for_gitlink() from treat_gitlinks() for reuse)
but the implementation was removed in 5a76aff1a6 (2013-07-14, add:
convert to use parse_pathspec).

Remove the declaration from the header as well.

Signed-off-by: Stefan Beller <redacted>
---
 pathspec.h | 1 -
 1 file changed, 1 deletion(-)
diff --git a/pathspec.h b/pathspec.h
index 0c11262..b596aed 100644
--- a/pathspec.h
+++ b/pathspec.h
@@ -96,7 +96,6 @@ static inline int ps_strcmp(const struct pathspec_item *item,

 extern char *find_pathspecs_matching_against_index(const struct pathspec *pathspec);
 extern void add_pathspec_matches_against_index(const struct pathspec *pathspec, char *seen);
-extern const char *check_path_for_gitlink(const char *path);
 extern void die_if_path_beyond_symlink(const char *path, const char *prefix);

 #endif /* PATHSPEC_H */
Interesting.

I wonder if the patches mentioned have something to do with the "git
add deep/in/the/tree" that fails to notice deep/in/ is an unrelated
repository in some way?
Which is considered a feature now. Maybe we should add tests for that?

http://debuggable.com/posts/git-fake-submodules:4b563ee4-f3cc-4061-967e-0e48cbdd56cb
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help