Re: [PATCH v3 1/2] Documentation: fix linkgit references

2 messages, 2 authors, 2016-06-16 · open the first message on its own page

Re: [PATCH v3 1/2] Documentation: fix linkgit references

From: Junio C Hamano <hidden>
Date: 2016-06-16 02:19:09

Lars Schneider [off-list ref] writes:
On 02 May 2016, at 22:34, Jeff King [off-list ref] wrote:
quoted
On Mon, May 02, 2016 at 10:20:04PM +0200, larsxschneider@gmail.com wrote:
quoted
From: Lars Schneider <redacted>

Signed-off-by: Lars Schneider <redacted>
---
Fix how? Your commit message doesn't say why this is a good idea. Since
this is v3, I'm guessing that reasoning is on the list, but it needs to
be summarized here in the commit message.
You are right, I should have explained my thinking a bit more detailed. 
A few of the fixed linkgit references are just typos, e.g.:

-linkgit:gitconfig[5]
+linkgit:git-config[5]
I didn't run "git blame" yet, so it might be that we used to have it
in section 5, but "git config --help" puts the latter in section 1.

Even though you obviously were fooled by AsciiDoctor regarding
literal double dash {litdd}, other parts of the changes did look
good typofixes.  Thanks for starting this.

Re: [PATCH v3 1/2] Documentation: fix linkgit references

From: Jeff King <hidden>
Date: 2016-06-16 02:19:09

On Tue, May 03, 2016 at 08:41:37AM -0700, Junio C Hamano wrote:
Even though you obviously were fooled by AsciiDoctor regarding
literal double dash {litdd}, other parts of the changes did look
good typofixes.  Thanks for starting this.
Yeah, I stopped reading after seeing the first hunk, but I agree the
rest look trivial.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help