Re: [PATCH v8 10/10] ce_compare_data() did not respect conversion

tboegi@web.de writes:

From: Torsten Bögershausen <redacted>

We define the working tree file is clean if either:

  * the result of running convert_to_git() on the working tree
    contents matches what is in the index (because that would mean
    doing another "git add" on the path is a no-op); OR

  * the result of running convert_to_working_tree() on the content
    in the index matches what is in the working tree (because that
    would mean doing another "git checkout -f" on the path is a
    no-op).

Add an extra check in ce_compare_data() in read_cache.c.

Helped-by: Junio C Hamano [off-list ref]

Well, didn't I do exactly the above much earlier and discarded it
because that breaks the definition of "diff"?  Or is this doing
something differently?

On 29.04.16 23:09, Junio C Hamano wrote:

Well, didn't I do exactly the above much earlier and discarded it
because that breaks the definition of "diff"?  Or is this doing
something differently?

Yes, and I try to sneak it in anyway ;-)

I spend some time debugging how to get t6038 passed, and need
some more time.

If 10/10 is a no-go (and it probably should be),
does it make sense to keep 1/10..4/10 and discard 5..10 for the moment ?