Re: [PATCH v1 2/2] git-p4: fix Git LFS pointer parsing

Lars Schneider [off-list ref] writes:

quoted

On 19 Apr 2016, at 22:30, Junio C Hamano [off-list ref] wrote:

larsxschneider@gmail.com writes:

quoted

From: Lars Schneider <redacted>

Git LFS 1.2.0 removed a line from the output of the 'git lfs pointer'
command [1] which broke the parsing of this output. Adjust the parser
to the new output and add minimum Git LFS version to the docs.

Hmph, adjust to operate with both, or drop the support for the old
one?

I dropped the support for the older version to keep the code as
simple as possible (plus it would be cumbersome to test with an
outdated Git LFS version). Since it is probably a niche feature I
thought that might be acceptable.

It is bad enough that clients need to be adjusted at all in the
first place, but I would have found it very troubling if the
problematic change to LFS thing were made in such a way that it
makes backward compatible adjustment on the client code impossible.

But it seems that you could read their output and strip a line that
begins with a known substring to make it compatible with both?

"git P4" itself may be niche and using it with the LFS thing may
even be more so, but in Git land, traditionally we take the backward
compatibility seriously.  If it is not too much work, I'd prefer to
see this done the right way.

Thanks.

On Tue, Apr 19, 2016 at 11:04 PM, Junio C Hamano [off-list ref] wrote:

quoted

I dropped the support for the older version to keep the code as
simple as possible (plus it would be cumbersome to test with an
outdated Git LFS version). Since it is probably a niche feature I
thought that might be acceptable.

It is bad enough that clients need to be adjusted at all in the
first place, but I would have found it very troubling if the
problematic change to LFS thing were made in such a way that it
makes backward compatible adjustment on the client code impossible.

If clients rely on output targeted at human consumption it's not
surprising that these clients need to be adjusted from time to time.
What's troubling is not the change to git-lfs, but the very un-generic
way git-p4 is implemented.

-- 
Sebastian Schuberth