DORMANTno replies

[PATCH resubmission] config.mak.uname: Cygwin: Use renames for creation

From: Adam Dinwoodie <hidden>
Date: 2016-06-16 02:18:51
Subsystem: the rest · Maintainer: Linus Torvalds

When generating build options for Cygwin, enable
OBJECT_CREATION_USES_RENAMES.  This is necessary to use Git on Windows
shared directories, and is already enabled for the MinGW and plain
Windows builds.

Reported-by: Peter Rosin <peda@lysator.liu.se>
Signed-off-by: Adam Dinwoodie <redacted>
---

This patch has previously been discussed on the mailing list (see
http://thread.gmane.org/gmane.comp.version-control.git/275485), back in
August 2015.  The conclusion then was that the downstream Cygwin builds
should take this patch for a few Git releases, and then resubmit the
patch to be taken upstream if it was causing no problems.

As the Cygwin Git maintainer, I've been applying this patch downstream
since v2.4.5-3 (where the "-3" is the Cygwin build/patch number), and
I've seen no reports of problems caused by this patch, and the reports
of Git on Cygwin being unable to work with Windows shared directories
have stopped.  As such, I'm resubmitting.

 config.mak.uname | 1 +
 1 file changed, 1 insertion(+)
diff --git a/config.mak.uname b/config.mak.uname
index 943c439..be5cbec 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -187,6 +187,7 @@ ifeq ($(uname_O),Cygwin)
 	X = .exe
 	UNRELIABLE_FSTAT = UnfortunatelyYes
 	SPARSE_FLAGS = -isystem /usr/include/w32api -Wno-one-bit-signed-bitfield
+	OBJECT_CREATION_USES_RENAMES = UnfortunatelyNeedsTo
 endif
 ifeq ($(uname_S),FreeBSD)
 	NEEDS_LIBICONV = YesPlease
-- 
2.4.5
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help