Re: [PATCH] git-stash: Don't GPG sign when stashing changes

Hi Cameron,

On Wed, 13 Apr 2016, Cameron Currie wrote:

quoted

quoted

On Thu, 7 Apr 2016, daurnimator wrote:

quoted

Cameron Currie <me <at> cameroncurrie.net> writes:

quoted

This is helpful for folks with commit.gpgsign = true in their
.gitconfig.

quoted

https://github.com/git/git/pull/186

I too would like this.
Bumping due to lack of attention.

It lacks a Sign-off, our convention is to continue in lower-case
after the colon in the commit's subject, and I think that it would
be good to write so much as one paragraph in the commit message.

I don't think I can find the time right now. Feel free to rewrite the
commit message to match convention.

I am afraid that it would be improper for anybody to add your Sign-off, as
it is *your* statement that you are indeed contributing this as Open
Source, and that you indeed are free to do so.

If you do not find the time to take care of these small changes, I fear
the Git maintainer will *have* to drop your patch to avoid hassle for
himself.

Ciao,
Johannes

On 15 April 2016 at 01:50, Johannes Schindelin
[off-list ref] wrote:

Hi Cameron,

On Wed, 13 Apr 2016, Cameron Currie wrote:

quoted

quoted

quoted

On Thu, 7 Apr 2016, daurnimator wrote:

quoted

Cameron Currie <me <at> cameroncurrie.net> writes:

quoted

This is helpful for folks with commit.gpgsign = true in their
.gitconfig.

quoted

https://github.com/git/git/pull/186

I too would like this.
Bumping due to lack of attention.

It lacks a Sign-off, our convention is to continue in lower-case
after the colon in the commit's subject, and I think that it would
be good to write so much as one paragraph in the commit message.

I don't think I can find the time right now. Feel free to rewrite the
commit message to match convention.

I am afraid that it would be improper for anybody to add your Sign-off, as
it is *your* statement that you are indeed contributing this as Open
Source, and that you indeed are free to do so.

If you do not find the time to take care of these small changes, I fear
the Git maintainer will *have* to drop your patch to avoid hassle for
himself.

Ciao,
Johannes

Cameron, could you please add a sign off to your commit?
It should be as simple as running `git commit --amend -s`