Eric Sunshine [off-list ref] writes:
quoted
Given that the ifndef/endif block immediately before this part is
also about excluding -p/-u/--patch when formatting the documentation
for format-patch, perhaps the attached may be a smaller equivalent?
Perhaps. I kept self-contained to make it easier to add new options
between the two if need be, but I don't feel strongly about it.
I don't either, but the reason why I thought it would make sense to
have them in the same block is because hiding --no-patch and --patch
are about the same theme: format-patch is about presenting the diff,
and neither disabling diff output nor explicitly asking for diff
output makes sense.
So...
On Mon, Apr 4, 2016 at 4:07 PM, Junio C Hamano [off-list ref] wrote:
Eric Sunshine [off-list ref] writes:
quoted
quoted
Given that the ifndef/endif block immediately before this part is
also about excluding -p/-u/--patch when formatting the documentation
for format-patch, perhaps the attached may be a smaller equivalent?
Perhaps. I kept self-contained to make it easier to add new options
between the two if need be, but I don't feel strongly about it.
I don't either, but the reason why I thought it would make sense to
have them in the same block is because hiding --no-patch and --patch
are about the same theme: format-patch is about presenting the diff,
and neither disabling diff output nor explicitly asking for diff
output makes sense.
That's reasonable. Should I re-roll, or would you like to amend it locally?
On Mon, Apr 4, 2016 at 6:38 PM, Eric Sunshine [off-list ref] wrote:
On Mon, Apr 4, 2016 at 4:07 PM, Junio C Hamano [off-list ref] wrote:
quoted
Eric Sunshine [off-list ref] writes:
quoted
quoted
Given that the ifndef/endif block immediately before this part is
also about excluding -p/-u/--patch when formatting the documentation
for format-patch, perhaps the attached may be a smaller equivalent?
Perhaps. I kept self-contained to make it easier to add new options
between the two if need be, but I don't feel strongly about it.
I don't either, but the reason why I thought it would make sense to
have them in the same block is because hiding --no-patch and --patch
are about the same theme: format-patch is about presenting the diff,
and neither disabling diff output nor explicitly asking for diff
output makes sense.
That's reasonable. Should I re-roll, or would you like to amend it locally?
Okay, I just pulled upon seeing "What's Cooking" and see that you
amended it locally. Thanks.