Re: [PATCH v4] commit: add a commit.verbose...

Re: [PATCH v4] commit: add a commit.verbose config variable

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:08:42

Pranit Bauva [off-list ref] writes:

+	if (!strcmp(k, "commit.verbose")){

v3 did this line correctly but you somehow lost the SP between
"){".  What happened?

quoted hunk

diff --git a/t/t7507-commit-verbose.sh b/t/t7507-commit-verbose.sh
index 2ddf28c..4e123a5 100755
--- a/t/t7507-commit-verbose.sh
+++ b/t/t7507-commit-verbose.sh

@@ -96,4 +96,52 @@ test_expect_success 'verbose diff is stripped out with set core.commentChar' '
 	test_i18ngrep "Aborting commit due to empty commit message." err
 '
 
+test_expect_success 'commit with commit.verbose true and no arguments' '
+test_expect_success 'commit with commit.verbose true and --no-verbose' '
+test_expect_success 'commit with commit.verbose false and -v' '
+test_expect_success 'commit with commit.verbose false no arguments' '

Don't you need a test that status is not broken when the variable is
set?

Re: [PATCH v4] commit: add a commit.verbose config variable

From: Pranit Bauva <hidden>
Date: 2016-06-15 23:08:42

+     if (!strcmp(k, "commit.verbose")){

v3 did this line correctly but you somehow lost the SP between
"){".  What happened?

I will include the SP between )) and { .

Don't you need a test that status is not broken when the variable is
set?

I will include the test for status too. But I am a bit confused where
should I place them? This patch triggers the possibility of a breakage
in status related to verbose but other tests related to status are in
different files. Could you tell me the filename where I should place
these test?

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help