Re: [PATCH 16/22] run-command.c: mark strings for translation

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH 16/22] run-command.c: mark strings for translation

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:08:33

Nguyễn Thái Ngọc Duy  [off-list ref] writes:
Signed-off-by: Nguyễn Thái Ngọc Duy <redacted>
---
This is new and there aren't many non-BUG messages that are not
marked, so let's take this one for 2.8.0.

quoted hunk
 run-command.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/run-command.c b/run-command.c
index 863dad5..1ee2357 100644
--- a/run-command.c
+++ b/run-command.c
@@ -909,7 +909,7 @@ static int default_start_failure(struct child_process *cp,
 {
 	int i;
 
-	strbuf_addstr(err, "Starting a child failed:");
+	strbuf_addstr(err, _("Starting a child failed:"));
 	for (i = 0; cp->argv[i]; i++)
 		strbuf_addf(err, " %s", cp->argv[i]);
 
@@ -927,7 +927,7 @@ static int default_task_finished(int result,
 	if (!result)
 		return 0;
 
-	strbuf_addf(err, "A child failed with return code %d:", result);
+	strbuf_addf(err, _("A child failed with return code %d:"), result);
 	for (i = 0; cp->argv[i]; i++)
 		strbuf_addf(err, " %s", cp->argv[i]);

Re: [PATCH 16/22] run-command.c: mark strings for translation

From: Stefan Beller <hidden>
Date: 2016-06-15 23:08:33

On Mon, Feb 29, 2016 at 10:52 AM, Junio C Hamano [off-list ref] wrote:
Nguyễn Thái Ngọc Duy  [off-list ref] writes:
quoted
Signed-off-by: Nguyễn Thái Ngọc Duy <redacted>
---
This is new and there aren't many non-BUG messages that are not
marked, so let's take this one for 2.8.0.
This would collide with "[PATCH] run-command: do not pass child
process data into callbacks",
dropping this patch would be easiest.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help