[PATCH] fetch-pack: fix unadvertised requests validation
From: Gabriel Souza Franco <hidden>
Date: 2016-06-15 23:08:31
Subsystem:
the rest · Maintainer:
Linus Torvalds
Check was introduced in b791642 (filter_ref: avoid overwriting ref->old_sha1 with garbage, 2015-03-19), but was always false because ref->old_oid.hash is empty in this case. Instead copy sha1 from ref->name. Signed-off-by: Gabriel Souza Franco <redacted> --- fetch-pack.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fetch-pack.c b/fetch-pack.c
index 01e34b6..83b937b 100644
--- a/fetch-pack.c
+++ b/fetch-pack.c@@ -569,11 +569,11 @@ static void filter_refs(struct fetch_pack_args *args, if (ref->matched) continue; if (get_sha1_hex(ref->name, sha1) || - ref->name[40] != '\0' || - hashcmp(sha1, ref->old_oid.hash)) + ref->name[40] != '\0') continue; ref->matched = 1; + hashcpy(ref->old_oid.hash, sha1); *newtail = copy_ref(ref); newtail = &(*newtail)->next; }
--
2.7.1