Re: [PATCH] git-completion.bash: always swallow error output of for-each-ref

Junio C Hamano [off-list ref] writes:

Jeff King [off-list ref] writes:

quoted

On Fri, Feb 12, 2016 at 10:40:48PM +0100, SZEDER Gábor wrote:

quoted

 * It would swallow even those errors that we are interested in,
   e.g. (note the missing quotes around $foo):
[...]
 * I often find myself tracing/debugging the completion script
   through stderr by scattering

      echo >&2 "foo: '$foo'"

One alternative to deal with these would be to add a flag to
conditionally turn off stderr, and then leave it on during normal
operation and disable it (letting everything through, including whatever
random cruft git commands produce) for debugging.

But...

quoted

 * I have a WIP patch series that deals with errors from git
   commands.

I'm happy to wait and see what this patch looks like (and generally
happy to defer to you on maintenance issues for completion, as you are
much more likely than me to be the one fixing things later on :) ).

-Peff

Likewise on both counts.

So, have we decided to wait, or we'd rather apply the band-aid in
the meantime?  I can go either way, just double checking as I
noticed this thread while updating my leftover bits list.

Thanks.

On Wed, Feb 24, 2016 at 12:30 AM, Junio C Hamano [off-list ref] wrote:

So, have we decided to wait, or we'd rather apply the band-aid in
the meantime?  I can go either way, just double checking as I
noticed this thread while updating my leftover bits list.

Thanks for the follow-up, I was about to ask for a status update on
this. As my patch it ready now, and we don't know how long we'd have
to wait for the other solution, I'd vote for applying my patch.

-- 
Sebastian Schuberth