Re: [PATCH v2] t0027: Add tests for get_stream_filter()

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH v2] t0027: Add tests for get_stream_filter()

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:07:54

tboegi@web.de writes:
From: Torsten Bögershausen <redacted>

When a filter is configured, a different code-path is used in
convert.c and entry.c via get_stream_filter(), but there are no test cases yet.

Add tests for the filter API by configuring the ident filter.
The result of the SHA1 conversion is not checked, this is already
done in other TC.

Add a parameter to checkout_files() in t0027.
While changing the signature, add another parameter for the eol= attribute.
This is currently unused, tests for e.g.
"* text=auto eol=lf" will be added in a separate commit.

Signed-off-by: Torsten Bögershausen <redacted>
---
- This needs to go on top of  tb/ls-files-eol
With missing "separate commit", I am having a hard time to decide if
this is something I should pick up at this moment, or I should wait
until that separate commit materializes.  What is your intention?

Thanks.

Re: [PATCH v2] t0027: Add tests for get_stream_filter()

From: Torsten Bögershausen <hidden>
Date: 2016-06-15 23:07:55

- This needs to go on top of  tb/ls-files-eol
With missing "separate commit", I am having a hard time to decide if
this is something I should pick up at this moment, or I should wait
until that separate commit materializes.  What is your intention?
I send a serious including this patch the next days.
If there are more review comments, they are welcome.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help