Re: [PATCH 10/10] t/t9001-send-email.sh: get rid of unnecessary backquotes

Elia Pinto [off-list ref] writes:

Instead of making the shell expand 00* and invoke 'echo' with it,
and then capturing its output as command substitution, just use
the result of expanding 00* directly.

This is not actually how it happens. cover=`echo *` expands the * before
the assignment to $cover, while cover="*" assigns a litteral * to
$cover.

Then, when you use $cover, the variable is expanded to * and then it is
expanded to filenames here:

 	mv $cover cover-to-edit.patch &&

On the other hand, this instance of $cover is quoted, hence the
*-expansion won't happen:

 	perl -pe "s/^From:/$header: extra\@address.com\nFrom:/" cover-to-edit.patch >"$cover" &&

So, I believe this patch is not correct.

OTOH, patches 1 to 9 look good to me.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

2016-01-08 15:52 GMT+01:00 Matthieu Moy [off-list ref]:

Elia Pinto [off-list ref] writes:

quoted

Instead of making the shell expand 00* and invoke 'echo' with it,
and then capturing its output as command substitution, just use
the result of expanding 00* directly.

This is not actually how it happens. cover=`echo *` expands the * before
the assignment to $cover, while cover="*" assigns a litteral * to
$cover.

Then, when you use $cover, the variable is expanded to * and then it is
expanded to filenames here:

quoted

      mv $cover cover-to-edit.patch &&

On the other hand, this instance of $cover is quoted, hence the
*-expansion won't happen:

quoted

      perl -pe "s/^From:/$header: extra\@address.com\nFrom:/" cover-to-edit.patch >"$cover" &&

So, I believe this patch is not correct.

OTOH, patches 1 to 9 look good to me.

Yup. I am really sorry. I was not aware of the particular case,
despite having tested the patch.

Thanks for the review. Junio you kindly remove this patch?

Thank you all very much.

Sorry about the noise

Best regards

--
Matthieu Moy
http://www-verimag.imag.fr/~moy/