Nguyễn Thái Ngọc Duy [off-list ref] writes:
... Now I conclude
that setup-messed-by-alias is always evil. So the env restoration is
done for _all_ commands whenever aliases are involved.
So a side effect of this is whenever an alias is involved, all
commands are re-spawned, not just the external ones but builtins as
well.
This may be a brilliant fix, or another invitation for regressions.
;-)
On Fri, Dec 4, 2015 at 9:35 PM, Junio C Hamano [off-list ref] wrote:
Nguyễn Thái Ngọc Duy [off-list ref] writes:
quoted
... Now I conclude
that setup-messed-by-alias is always evil. So the env restoration is
done for _all_ commands whenever aliases are involved.
So a side effect of this is whenever an alias is involved, all
commands are re-spawned, not just the external ones but builtins as
well.
I missed that while re-reading c056261, but yes that's true. So
Windows folks will be grumpy anyway. Maybe we can avoid that in
certain (safe) cases, when we know the second setup_git_... will be
executed by the builtin command and won't have any side effects, which
is probably the common case. But let's see how it goes.
--
Duy