Re: [PATCH v4] Add git-grep threads param

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH v4] Add git-grep threads param

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:07:09

Victor Leschuk [off-list ref] writes:
do we have any objections on this patch?
The question you should be asking is "do we have any support".

It is not like the default for any series is to be included; it is
quite the opposite.  "Is this worth having in our tree?" is the
question we all ask ourselves.

Also I think you should have CC'ed those who gave review comments on
this topic in the earlier rounds, if you wanted to receive answers
to that question (whichever one it is ;-).

Having said that, I didn't immediately spot anything objectionable.

Thanks.

RE: [PATCH v4] Add git-grep threads param

From: Victor Leschuk <hidden>
Date: 2016-06-15 23:07:10

quoted
do we have any objections on this patch?
The question you should be asking is "do we have any support".
Hello all, CCing participated reviewers. As Junio  has correctly mentioned: "Do we have any support for including this functionality?"

I think this kind of customization can be useful in tuning up performance as confirmed by conducted tests. And in most cases having anything hard-coded is worse than giving users opportunity to change it, isn't it?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help