Re: [PATCH v2 00/10] port branch.c to use ref-filter's printing options

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH v2 00/10] port branch.c to use ref-filter's printing options

From: Matthieu Moy <hidden>
Date: 2016-06-15 23:06:49

Karthik Nayak [off-list ref] writes:
Also does it make sense to integrate these changes here? Or would you like to
have another series on this?
To me, the important in this series is to avoid introducing duplicated
and inconsistent code, because it would make further refactoring harder.

But this series starts getting close to finished, so you should not try
to add to much to it (at least for me: I spend some time reviewing v2
and I have an idea of what the interdiff should look like, I'd rather
avoid having new distraction in the v2->v3 interdiff).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

Re: [PATCH v2 00/10] port branch.c to use ref-filter's printing options

From: Karthik Nayak <hidden>
Date: 2016-06-15 23:06:49

On Sun, Oct 11, 2015 at 9:51 PM, Matthieu Moy
[off-list ref] wrote:
Karthik Nayak [off-list ref] writes:
quoted
Also does it make sense to integrate these changes here? Or would you like to
have another series on this?
To me, the important in this series is to avoid introducing duplicated
and inconsistent code, because it would make further refactoring harder.
Would you suggest duplicating whats done with %(align) here?
But this series starts getting close to finished, so you should not try
to add to much to it (at least for me: I spend some time reviewing v2
and I have an idea of what the interdiff should look like, I'd rather
avoid having new distraction in the v2->v3 interdiff).
Yes! makes sense, thanks :)

-- 
Regards,
Karthik Nayak
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help