Re: [PATCH v2 2/4] Add prereq to detect OS X

larsxschneider@gmail.com writes:

From: Lars Schneider <redacted>

Some Unix tools differ between Linux and Mac OS X. Add this prereq to
detect OS X and handle it appropriately.

If my comment on 4/4 turns out to be to the point, then we do not
need this, I presume?  In general, we really should think three
times before adding prerequisite based on the platform.  A prereq
based on a specific feature of the platform is often what we want
instead.

On 04 Oct 2015, at 11:28, Junio C Hamano [off-list ref] wrote:

larsxschneider@gmail.com writes:

quoted

From: Lars Schneider <redacted>

Some Unix tools differ between Linux and Mac OS X. Add this prereq to
detect OS X and handle it appropriately.

If my comment on 4/4 turns out to be to the point, then we do not
need this, I presume?  In general, we really should think three
times before adding prerequisite based on the platform.  A prereq
based on a specific feature of the platform is often what we want
instead.

Agreed. I will remove this commit in the next roll.

Thanks,
Lars