Re: [PATCH v8 0/7] git-p4: add support for large file systems

Junio C Hamano [off-list ref] writes:

Luke Diamand [off-list ref] writes:

quoted

All looks good to me, Ack.

One tiny thing perhaps Junio could comment on: the git commit message
for 75abe9fa5b39980de27dfc33dd5b4f4b5926f34c, "git-p4: add optional
type specifier to gitConfig reader" uses what looks like UTF-8 encoded
left and right quotes, rather than regular ASCII quotes ("). I don't
know if that matters.

Yeah, I noticed them, too.  In general, I'd prefer to avoid these
pretty-quotes myself, as they typically do not add much information
(unless nesting matters, which is usually not the case in the log
message, or something) and the primary effect of them is to force us
to step outside ASCII, which causes editors and pagers to misalign
for some people.

But it is not too huge an issue that it is worth to go back and fix
them, either.

Well, I looked at it again and it also replaced double-dash before
option names like --bool and --int with something funny (are these
em-dashes?), which is a more serious bogosity than pretty quotes, so
I ended up amending the message for that commit after all.

Thanks.

On 03 Oct 2015, at 10:23, Junio C Hamano [off-list ref] wrote:

Junio C Hamano [off-list ref] writes:

quoted

Luke Diamand [off-list ref] writes:

quoted

All looks good to me, Ack.

One tiny thing perhaps Junio could comment on: the git commit message
for 75abe9fa5b39980de27dfc33dd5b4f4b5926f34c, "git-p4: add optional
type specifier to gitConfig reader" uses what looks like UTF-8 encoded
left and right quotes, rather than regular ASCII quotes ("). I don't
know if that matters.

Yeah, I noticed them, too.  In general, I'd prefer to avoid these
pretty-quotes myself, as they typically do not add much information
(unless nesting matters, which is usually not the case in the log
message, or something) and the primary effect of them is to force us
to step outside ASCII, which causes editors and pagers to misalign
for some people.

But it is not too huge an issue that it is worth to go back and fix
them, either.

Well, I looked at it again and it also replaced double-dash before
option names like --bool and --int with something funny (are these
em-dashes?), which is a more serious bogosity than pretty quotes, so
I ended up amending the message for that commit after all.

Oh. This was not intentional. I wonder how that happened. I will watch out for it in the future.

Thanks for fixing,
Lars