Re: [PATCH v7 1/7] git-p4: add optional type specifier to gitConfig reader

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH v7 1/7] git-p4: add optional type specifier to gitConfig reader

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:06:39

larsxschneider@gmail.com writes:
From: Lars Schneider <redacted>

The functions “gitConfig” and “gitConfigBool” are almost identical. Make “gitConfig” more generic by adding an optional type specifier. Use the type specifier “—bool” with “gitConfig” to implement “gitConfigBool. This prepares the implementation of other type specifiers such as “—int”.
What is this overlong single line paragraph?  Is this a MUA artifact
on my end?

Re: [PATCH v7 1/7] git-p4: add optional type specifier to gitConfig reader

From: Lars Schneider <hidden>
Date: 2016-06-15 23:06:39

On 22 Sep 2015, at 23:49, Junio C Hamano [off-list ref] wrote:
larsxschneider@gmail.com writes:
quoted
From: Lars Schneider <redacted>

The functions “gitConfig” and “gitConfigBool” are almost identical. Make “gitConfig” more generic by adding an optional type specifier. Use the type specifier “—bool” with “gitConfig” to implement “gitConfigBool. This prepares the implementation of other type specifiers such as “—int”.
What is this overlong single line paragraph?  Is this a MUA artifact
on my end?
No. It looks like I messed that up. Same is true for the commit “git-p4: add gitConfigInt reader”. I’ll be more careful in the future.

Sorry,
Lars
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help