From: Junio C Hamano <hidden> Date: 2016-06-15 23:06:39
Lars Schneider [off-list ref] writes:
This works.
OK, and thanks; as I don't do perforce, the squash was without any
testing.
Do we need the “-e” option?
In syntactic sense, no, but our codebase tends to prefer to have
one, because it is easier to spot which ones are the instructions if
you consistently have "-e" even when you give only one.
From: Michael Blume <hidden> Date: 2016-06-15 23:06:39
I'm seeing test failures
non-executable tests: t9825-git-p4-handle-utf16-without-bom.sh
ls -l shows that all the other tests are executable but t9825 isn't.
On Tue, Sep 22, 2015 at 9:02 AM, Junio C Hamano [off-list ref] wrote:
Lars Schneider [off-list ref] writes:
quoted
This works.
OK, and thanks; as I don't do perforce, the squash was without any
testing.
quoted
Do we need the “-e” option?
In syntactic sense, no, but our codebase tends to prefer to have
one, because it is easier to spot which ones are the instructions if
you consistently have "-e" even when you give only one.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Junio C Hamano <hidden> Date: 2016-06-15 23:06:39
Yup, this was privately reported and I just squashed a fix in right now ;-)
Thanks. "cd t && make test-lint" would have caught it.
On Tue, Sep 22, 2015 at 12:11 PM, Michael Blume [off-list ref] wrote:
I'm seeing test failures
non-executable tests: t9825-git-p4-handle-utf16-without-bom.sh
ls -l shows that all the other tests are executable but t9825 isn't.
On Tue, Sep 22, 2015 at 9:02 AM, Junio C Hamano [off-list ref] wrote:
quoted
Lars Schneider [off-list ref] writes:
quoted
This works.
OK, and thanks; as I don't do perforce, the squash was without any
testing.
quoted
Do we need the “-e” option?
In syntactic sense, no, but our codebase tends to prefer to have
one, because it is easier to spot which ones are the instructions if
you consistently have "-e" even when you give only one.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Lars Schneider <hidden> Date: 2016-06-15 23:06:39
Thanks a lot for taking care of this!
- Lars
On 22 Sep 2015, at 21:17, Junio C Hamano [off-list ref] wrote:
Yup, this was privately reported and I just squashed a fix in right now ;-)
Thanks. "cd t && make test-lint" would have caught it.
On Tue, Sep 22, 2015 at 12:11 PM, Michael Blume [off-list ref] wrote:
quoted
I'm seeing test failures
non-executable tests: t9825-git-p4-handle-utf16-without-bom.sh
ls -l shows that all the other tests are executable but t9825 isn't.
On Tue, Sep 22, 2015 at 9:02 AM, Junio C Hamano [off-list ref] wrote:
quoted
Lars Schneider [off-list ref] writes:
quoted
This works.
OK, and thanks; as I don't do perforce, the squash was without any
testing.
quoted
Do we need the “-e” option?
In syntactic sense, no, but our codebase tends to prefer to have
one, because it is easier to spot which ones are the instructions if
you consistently have "-e" even when you give only one.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html