Re: [PATCH] tag, update-ref: improve description of option "create-reflog"

Ralf Thielow [off-list ref] writes:

The description of option "create-reflog" is "create_reflog", which
is neither a good description, nor a sensible string to translate.
Change it to a more meaningful message.

Signed-off-by: Ralf Thielow <redacted>
---

This definitely is an improvement.  I will assume i18n team is OK
with a change like this this late in the cycle (I see you CC'ed
Jiang) and will merge before the next -rc.

Thanks.

2015-09-12 0:47 GMT+08:00 Junio C Hamano [off-list ref]:

Ralf Thielow [off-list ref] writes:

quoted

The description of option "create-reflog" is "create_reflog", which
is neither a good description, nor a sensible string to translate.
Change it to a more meaningful message.

Signed-off-by: Ralf Thielow <redacted>
---

This definitely is an improvement.  I will assume i18n team is OK
with a change like this this late in the cycle (I see you CC'ed
Jiang) and will merge before the next -rc.

Agree. Those who have already finished this round of l10n
(including sv (Swedish) and vi (Vietnamese)) should update
their translations for this update.

Thanks.

quoted

 builtin/tag.c        | 2 +-
 builtin/update-ref.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/builtin/tag.c b/builtin/tag.c
index cccca99..cba0e22 100644
--- a/builtin/tag.c
+++ b/builtin/tag.c

@@ -606,7 +606,7 @@ int cmd_tag(int argc, const char **argv, const char *prefix)
              OPT_STRING('u', "local-user", &keyid, N_("key-id"),
                                      N_("use another key to sign the tag")),
              OPT__FORCE(&force, N_("replace the tag if exists")),
-             OPT_BOOL(0, "create-reflog", &create_reflog, N_("create_reflog")),
+             OPT_BOOL(0, "create-reflog", &create_reflog, N_("create a reflog")),

              OPT_GROUP(N_("Tag listing options")),
              OPT_COLUMN(0, "column", &colopts, N_("show tag list in columns")),

diff --git a/builtin/update-ref.c b/builtin/update-ref.c
index 04dd00f..7f30d3a 100644
--- a/builtin/update-ref.c
+++ b/builtin/update-ref.c

@@ -365,7 +365,7 @@ int cmd_update_ref(int argc, const char **argv, const char *prefix)
                                      N_("update <refname> not the one it points to")),
              OPT_BOOL('z', NULL, &end_null, N_("stdin has NUL-terminated arguments")),
              OPT_BOOL( 0 , "stdin", &read_stdin, N_("read updates from stdin")),
-             OPT_BOOL( 0 , "create-reflog", &create_reflog, N_("create_reflog")),
+             OPT_BOOL( 0 , "create-reflog", &create_reflog, N_("create a reflog")),
              OPT_END(),
      };

-- 
Jiang Xin