Stefan Beller [off-list ref] writes:
+static void destroy_output_mutex()
static void destroy_output_mutex(void)
+{
+ pthread_mutex_destroy(&output_mutex);
+}
+
+#else
+#define set_output_mutex()
+#define destroy_output_mutex()
+#define lock_output_mutex()
+#define unlock_output_mutex()
+#endif
+
+static struct submodule_parallel_fetch *submodule_parallel_fetch_create()
static struct submodule_parallel_fetch *submodule_parallel_fetch_create(void)
On Mon, Aug 31, 2015 at 11:56:04AM -0700, Junio C Hamano wrote:
Stefan Beller [off-list ref] writes:
quoted
+static void destroy_output_mutex()
static void destroy_output_mutex(void)
Yep. Stefan, you may want to beef up the warning flags in your
config.mak. For reference, I use:
CFLAGS += -Wall -Werror
CFLAGS += -Wdeclaration-after-statement
CFLAGS += -Wpointer-arith
CFLAGS += -Wstrict-prototypes
CFLAGS += -Wvla
CFLAGS += -Wold-style-declaration
CFLAGS += -Wold-style-definition
though note that you will need to relax some of those if compiling older
versions of git. My complete config.mak is at:
https://github.com/peff/git/blob/meta/config/config.mak
which handles this semi-automatically (it's wildly undocumented, but I'd
be happy to explain any of it if anybody is interested).
-Peff