Re: [PATCH 05/17] remove hold_lock_file_for_append

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH 05/17] remove hold_lock_file_for_append

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:06:08

Jeff King [off-list ref] writes:
No users of hold_lock_file_for_append remain, so remove it.
This does not seem to have anything to do with rotating static buffers
used in get_pathname(); the only effect it has is to conflict heavily
with Michael's tempfile topic X-<.

Perhaps this should be part of Michael's tempfile topic?

Re: [PATCH 05/17] remove hold_lock_file_for_append

From: Jeff King <hidden>
Date: 2016-06-15 23:06:08

On Mon, Aug 10, 2015 at 03:36:14PM -0700, Junio C Hamano wrote:
Jeff King [off-list ref] writes:
quoted
No users of hold_lock_file_for_append remain, so remove it.
This does not seem to have anything to do with rotating static buffers
used in get_pathname(); the only effect it has is to conflict heavily
with Michael's tempfile topic X-<.
Yeah, the first patch (to drop the final caller) is why I stuck it in
this series, and I did not want to forget the rest of the topic that Jim
worked on.
Perhaps this should be part of Michael's tempfile topic?
Yes, I think that is OK. We can keep the first patch (to
add_to_alternates_file) here, and do the other one later on top of
Michael's topic.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help