Re: [PATCH v3] gitk: Add a "Copy commit summary" command

Eric Sunshine [off-list ref] writes:

quoted

Signed-off-by: Beat Bolli <redacted>
Reviewed-by: Eric Sunshine <redacted>
Reviewed-by: Johannes Sixt <redacted>

You should drop these Reviewed-by: footers, as they imply that the
code was thoroughly digested and the implementation deemed correct.

... and the most importantly, the named people said that themselves.

I do not think that happened here (yet).

quoted

+proc copysummary {} {
+    global rowmenuid
+
+    set format "%h (\"%s\", %ad)"
+    set summary [exec git show -s --pretty=format:$format --date=short \
+                 $rowmenuid]
+
+    clipboard clear
+    clipboard append $summary
+}
+

I think this is a reasonable implementation.  The usual "spawning a
process for each commit is too expensive" would not apply, because
it is done on demand only for the single commit that the end-user
specified.

On 17.07.15 19:28, Junio C Hamano wrote:

Eric Sunshine [off-list ref] writes:

quoted

quoted

Signed-off-by: Beat Bolli <redacted>
Reviewed-by: Eric Sunshine <redacted>
Reviewed-by: Johannes Sixt <redacted>

You should drop these Reviewed-by: footers, as they imply that the
code was thoroughly digested and the implementation deemed correct.

... and the most importantly, the named people said that themselves.

I do not think that happened here (yet).

quoted

quoted

+proc copysummary {} {
+    global rowmenuid
+
+    set format "%h (\"%s\", %ad)"
+    set summary [exec git show -s --pretty=format:$format --date=short \
+                 $rowmenuid]
+
+    clipboard clear
+    clipboard append $summary
+}
+

I think this is a reasonable implementation.  The usual "spawning a
process for each commit is too expensive" would not apply, because
it is done on demand only for the single commit that the end-user
specified.

Thanks, Junio! That was my thought as well.

So, the question remains now if adding something like
--abbrev=$autosellen (maybe only if it's not set to its default value),
as Paul suggested, would make sense.

Beat