[PATCH] gitk: Add a "Copy commit summary" command

Subsystems: the rest

STALE3738d

5 messages, 5 authors, 2016-06-15 · open the first message on its own page

[PATCH] gitk: Add a "Copy commit summary" command

From: <hidden>
Date: 2016-06-15 23:05:45

From: Beat Bolli <redacted>

When referencing earlier commits in new commit messages or other text,
one of the established formats is

    commit <abbrev-sha> ("<summary>", <author-date>)

Add a "Copy commit summary" command to the context menu that puts this
text for the currently selected commit on the clipboard. This makes it
easy for our users to create well-formatted commit references.

Signed-off-by: Beat Bolli <redacted>
Cc: Paul Mackerras <redacted>
---
 gitk-git/gitk | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index 9a2daf3..0612331 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -2617,6 +2617,7 @@ proc makewindow {} {
 	{mc "Diff selected -> this" command {diffvssel 1}}
 	{mc "Make patch" command mkpatch}
 	{mc "Create tag" command mktag}
+	{mc "Copy commit summary" command copysummary}
 	{mc "Write commit to file" command writecommit}
 	{mc "Create new branch" command mkbranch}
 	{mc "Cherry-pick this commit" command cherrypick}
@@ -9341,6 +9342,19 @@ proc mktaggo {} {
     mktagcan
 }
 
+proc copysummary {} {
+    global rowmenuid commitinfo
+
+    set id [string range $rowmenuid 0 7]
+    set info $commitinfo($rowmenuid)
+    set commit [lindex $info 0]
+    set date [formatdate [lindex $info 2]]
+    set summary "[mc "commit"] $id (\"$commit\", $date)"
+
+    clipboard clear
+    clipboard append $summary
+}
+
 proc writecommit {} {
     global rowmenuid wrcomtop commitinfo wrcomcmd NS
 
-- 
2.1.4

Re: [PATCH] gitk: Add a "Copy commit summary" command

From: Stefan Beller <hidden>
Date: 2016-06-15 23:05:45

On Tue, Jul 14, 2015 at 9:42 AM,  [off-list ref] wrote:
From: Beat Bolli <redacted>

When referencing earlier commits in new commit messages or other text,
one of the established formats is

    commit <abbrev-sha> ("<summary>", <author-date>)
That sounds like I would use it a lot! Thanks :)
quoted hunk
Add a "Copy commit summary" command to the context menu that puts this
text for the currently selected commit on the clipboard. This makes it
easy for our users to create well-formatted commit references.

Signed-off-by: Beat Bolli <redacted>
Cc: Paul Mackerras <redacted>
---
 gitk-git/gitk | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index 9a2daf3..0612331 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -2617,6 +2617,7 @@ proc makewindow {} {
        {mc "Diff selected -> this" command {diffvssel 1}}
        {mc "Make patch" command mkpatch}
        {mc "Create tag" command mktag}
+       {mc "Copy commit summary" command copysummary}
        {mc "Write commit to file" command writecommit}
        {mc "Create new branch" command mkbranch}
        {mc "Cherry-pick this commit" command cherrypick}
@@ -9341,6 +9342,19 @@ proc mktaggo {} {
     mktagcan
 }

+proc copysummary {} {
+    global rowmenuid commitinfo
+
+    set id [string range $rowmenuid 0 7]
+    set info $commitinfo($rowmenuid)
+    set commit [lindex $info 0]
+    set date [formatdate [lindex $info 2]]
+    set summary "[mc "commit"] $id (\"$commit\", $date)"
+
+    clipboard clear
+    clipboard append $summary
+}
+
 proc writecommit {} {
     global rowmenuid wrcomtop commitinfo wrcomcmd NS

--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] gitk: Add a "Copy commit summary" command

From: "Keller, Jacob E" <jacob.e.keller@intel.com>
Date: 2016-06-15 23:05:46

On Tue, 2015-07-14 at 13:34 -0700, Stefan Beller wrote:
On Tue, Jul 14, 2015 at 9:42 AM,  [off-list ref] wrote:
quoted
From: Beat Bolli <redacted>

When referencing earlier commits in new commit messages or other 
text,
one of the established formats is

    commit <abbrev-sha> ("<summary>", <author-date>)
That sounds like I would use it a lot! Thanks :)
Yep, quite useful. Also, the kernel suggests using it as a tag like so

Fixes: <abbrev-sha> ("summary")

I really like this :)

Regards,
Jake
quoted
Add a "Copy commit summary" command to the context menu that puts 
this
text for the currently selected commit on the clipboard. This makes 
it
easy for our users to create well-formatted commit references.

Signed-off-by: Beat Bolli <redacted>
Cc: Paul Mackerras <redacted>
---
 gitk-git/gitk | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index 9a2daf3..0612331 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -2617,6 +2617,7 @@ proc makewindow {} {
        {mc "Diff selected -> this" command {diffvssel 1}}
        {mc "Make patch" command mkpatch}
        {mc "Create tag" command mktag}
+       {mc "Copy commit summary" command copysummary}
        {mc "Write commit to file" command writecommit}
        {mc "Create new branch" command mkbranch}
        {mc "Cherry-pick this commit" command cherrypick}
@@ -9341,6 +9342,19 @@ proc mktaggo {} {
     mktagcan
 }

+proc copysummary {} {
+    global rowmenuid commitinfo
+
+    set id [string range $rowmenuid 0 7]
+    set info $commitinfo($rowmenuid)
+    set commit [lindex $info 0]
+    set date [formatdate [lindex $info 2]]
+    set summary "[mc "commit"] $id (\"$commit\", $date)"
+
+    clipboard clear
+    clipboard append $summary
+}
+
 proc writecommit {} {
     global rowmenuid wrcomtop commitinfo wrcomcmd NS

--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] gitk: Add a "Copy commit summary" command

From: Eric Sunshine <hidden>
Date: 2016-06-15 23:05:46

On Wed, Jul 15, 2015 at 6:24 PM, Keller, Jacob E
[off-list ref] wrote:
On Tue, 2015-07-14 at 13:34 -0700, Stefan Beller wrote:
quoted
On Tue, Jul 14, 2015 at 9:42 AM,  [off-list ref] wrote:
quoted
From: Beat Bolli <redacted>

When referencing earlier commits in new commit messages or other
text,
one of the established formats is

    commit <abbrev-sha> ("<summary>", <author-date>)
That sounds like I would use it a lot! Thanks :)
Yep, quite useful. Also, the kernel suggests using it as a tag like so

Fixes: <abbrev-sha> ("summary")
Dropping the literal word "commit" would make this use-case more
convenient, as well as the typical use-case when composing commit
messages: "Since <abrrev-sha1> ("blah", <date>), foobar.c has
flabble-nabbered the wonka-doodle..."

Re: [PATCH] gitk: Add a "Copy commit summary" command

From: Jacob Keller <hidden>
Date: 2016-06-15 23:05:46

Agreed. I haven't seen "commit" used much in the past, and you can
easily type that out as it is.

On Wed, Jul 15, 2015 at 4:58 PM, Eric Sunshine [off-list ref] wrote:
On Wed, Jul 15, 2015 at 6:24 PM, Keller, Jacob E
[off-list ref] wrote:
quoted
On Tue, 2015-07-14 at 13:34 -0700, Stefan Beller wrote:
quoted
On Tue, Jul 14, 2015 at 9:42 AM,  [off-list ref] wrote:
quoted
From: Beat Bolli <redacted>

When referencing earlier commits in new commit messages or other
text,
one of the established formats is

    commit <abbrev-sha> ("<summary>", <author-date>)
That sounds like I would use it a lot! Thanks :)
Yep, quite useful. Also, the kernel suggests using it as a tag like so

Fixes: <abbrev-sha> ("summary")
Dropping the literal word "commit" would make this use-case more
convenient, as well as the typical use-case when composing commit
messages: "Since <abrrev-sha1> ("blah", <date>), foobar.c has
flabble-nabbered the wonka-doodle..."
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help