Re: [PATCH] Fix power checking on OS X

3 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH] Fix power checking on OS X

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:05:20

Panagiotis Astithas [off-list ref] writes:
The output of "pmset -g batt" changed at some point from
"Currently drawing from 'AC Power'" to the slightly different
"Now drawing from 'AC Power'". Starting the match from "drawing"
makes the check work in both old and new versions of OS X.

Signed-off-by: Panagiotis Astithas <redacted>
---
Hmph, is there any difference between this one and the original one
that I already queued several days ago?
quoted hunk
 contrib/hooks/pre-auto-gc-battery | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/hooks/pre-auto-gc-battery b/contrib/hooks/pre-auto-gc-battery
index 9d0c2d1..6a2cdeb 100755
--- a/contrib/hooks/pre-auto-gc-battery
+++ b/contrib/hooks/pre-auto-gc-battery
@@ -33,7 +33,7 @@ elif grep -q "AC Power \+: 1" /proc/pmu/info 2>/dev/null
 then
 	exit 0
 elif test -x /usr/bin/pmset && /usr/bin/pmset -g batt |
-	grep -q "Currently drawing from 'AC Power'"
+	grep -q "drawing from 'AC Power'"
 then
 	exit 0
 fi

Re: [PATCH] Fix power checking on OS X

From: Panagiotis Astithas <hidden>
Date: 2016-06-15 23:05:20

On Tue, Jun 16, 2015 at 8:32 PM, Junio C Hamano [off-list ref] wrote:
Panagiotis Astithas [off-list ref] writes:
quoted
The output of "pmset -g batt" changed at some point from
"Currently drawing from 'AC Power'" to the slightly different
"Now drawing from 'AC Power'". Starting the match from "drawing"
makes the check work in both old and new versions of OS X.

Signed-off-by: Panagiotis Astithas <redacted>
---
Hmph, is there any difference between this one and the original one
that I already queued several days ago?
None, I was just following the process outlined in SubmittingPatches
that mentions a separate email after the discussion is over.

Re: [PATCH] Fix power checking on OS X

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:05:20

Ah, thanks.  Not many people do that, so I was wondering what was going on ;-).

On Tue, Jun 16, 2015 at 10:35 AM, Panagiotis Astithas [off-list ref] wrote:
On Tue, Jun 16, 2015 at 8:32 PM, Junio C Hamano [off-list ref] wrote:
quoted
Panagiotis Astithas [off-list ref] writes:
quoted
The output of "pmset -g batt" changed at some point from
"Currently drawing from 'AC Power'" to the slightly different
"Now drawing from 'AC Power'". Starting the match from "drawing"
makes the check work in both old and new versions of OS X.

Signed-off-by: Panagiotis Astithas <redacted>
---
Hmph, is there any difference between this one and the original one
that I already queued several days ago?
None, I was just following the process outlined in SubmittingPatches
that mentions a separate email after the discussion is over.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help