Re: [RFC] send-email quote issues

Remi Lespinet [off-list ref] writes:

Currently, git send-email contains a function which splits at commas
with respect to quotes (parse_address_line introduced by
5012699d9840fe34fe0838ea0d529c2f32f76b82).

It seems I had missed this one, but indeed, it should probably be used
instead of split_at_commas in your series.

It is used to parse user input when there's no recipient specified. I
would like to use this function to parse --to, --cc and --bcc options,
but the execution of this function depends on whether the user has the
Perl library Mail::Address or not. This introduce a change in the
behaviour:

I would say that using parse_address_line is good for consistancy in Git
anyway. If the behavior of parse_address_line is broken on some
corner-cases, then it should be fixed anyway.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

Matthieu Moy [off-list ref] writes

I would say that using parse_address_line is good for consistancy in Git 
anyway. If the behavior of parse_address_line is broken on some 
corner-cases, then it should be fixed anyway. 

Ok, but I don't know what fixed means in these particular cases.
Actually the problem when we have a quote in a name is: Is this a
delimiter or is this an ascii char?

Currently the problem is solved by saying : it's an ascii char
unless there is two quotes aroung all the name (modulo minor
things). So if I write:

--to='"Jane, Kararina" Doe [off-list ref]'

they are considered characters. Which means that this is
different than:

--to='"Jane, Kararina Doe" [off-list ref]'

Is this expected?