Re: [RFC/PATCH 6/9] for-each-ref: add '--merged' and '--no-merged' options

Karthik Nayak [off-list ref] writes:

Add the '--merged' and '--no-merged' options provided by 'ref-filter'.
The '--merged' option lets the user to only list refs merged into the
named commit. The '--no-merged' option lets the user to only list refs
not merged into the named commit.

Add documentation for the same.

This also requires some tests. The algorithmic part will be validated by
'git tag --merged' using this library, but you need to check the
codepath from the command-line to the lib in for-each-ref.

I'd spell that "only refs that are not merged".

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

On 06/08/2015 11:23 PM, Matthieu Moy wrote:

Karthik Nayak [off-list ref] writes:

quoted

Add the '--merged' and '--no-merged' options provided by 'ref-filter'.
The '--merged' option lets the user to only list refs merged into the
named commit. The '--no-merged' option lets the user to only list refs
not merged into the named commit.

Add documentation for the same.

This also requires some tests. The algorithmic part will be validated by
'git tag --merged' using this library, but you need to check the
codepath from the command-line to the lib in for-each-ref.

quoted

@@ -38,6 +39,8 @@ int cmd_for_each_ref(int argc, const char **argv, const char *prefix)
  		OPT_CALLBACK(0, "points-at", &ref_cbdata.filter.points_at,
  			     N_("object"), N_("print only tags of the object"),
  			     parse_opt_points_at),
+		OPT_MERGED(&ref_cbdata.filter, N_("print only merged refs")),
+		OPT_NO_MERGED(&ref_cbdata.filter, N_("print only not merged refs")),

I'd spell that "only refs that are not merged".

Like I mentioned, no tests were written.
Will change that.

-- 
Regards,
Karthik