Re: [PATCHv2 3/3] git-p4: fixing --changes-block-size handling
From: Junio C Hamano <hidden>
Date: 2016-06-15 23:05:12
Lex Spoon [off-list ref] writes:
Unless I am reading something wrong, the "new_changes" variable could be dropped now. It was needed for the -m version for detecting the smallest change number that was returned. Otherwise it looks good to me.
Meaning that I should squash this in to 3/3, right?
diff --git a/git-p4.py b/git-p4.py
index f201f52..7009766 100755
--- a/git-p4.py
+++ b/git-p4.py@@ -780,10 +780,8 @@ def p4ChangesForPaths(depotPaths, changeRange, block_size): cmd = ['changes'] cmd += ["%s...@%d,%d" % (p, changeStart, end)] - new_changes = [] for line in p4_read_pipe_lines(cmd): changeNum = int(line.split(" ")[1]) - new_changes.append(changeNum) changes[changeNum] = True if end >= changeEnd:
--
2.4.3-495-gcb7a0d9