Re: [WIP/PATCH v4 6/8] for-each-ref: rename some functions and make them public

Christian Couder [off-list ref] writes:

sort_refs() -> ref_array_sort()
struct ref_sort -> struct ref_sort_criteria
default_sort() -> ref_default_sort_criteria()
opt_parse_sort() -> opt_parse_ref_sort_criteria()

BTW, having such summary in the log message would help review: we could
think and discuss the naming by looking just at the summary, and then
check that you did it correctly (easy).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

On June 1, 2015 12:08:57 PM GMT+05:30, Matthieu Moy [off-list ref] wrote:

Christian Couder [off-list ref] writes:

quoted

sort_refs() -> ref_array_sort()
struct ref_sort -> struct ref_sort_criteria
default_sort() -> ref_default_sort_criteria()
opt_parse_sort() -> opt_parse_ref_sort_criteria()

BTW, having such summary in the log message would help review: we could
think and discuss the naming by looking just at the summary, and then
check that you did it correctly (easy).

Yes agreed, will do that.