Re: [PATCH 2/2] commit: fix ending newline for template files

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH 2/2] commit: fix ending newline for template files

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:05:02

Eric Sunshine [off-list ref] writes:
Moreover, it lacks justification and explanation of why you consider
the cleanup unnecessary. History [1] indicates that its application to
-F but not -t was intentional.

[1]: bc92377 (commit: fix ending newline for template files, 2015-05-26)
Sorry, but the date of that commit seems to be too new to be
considered "history"; I do not seem to have it, either.

But I agree with you that I too failed to see why this change is
necessary or desirable in the explanation in the proposed log
message.

Re: [PATCH 2/2] commit: fix ending newline for template files

From: Eric Sunshine <hidden>
Date: 2016-06-15 23:05:02

On Thu, May 28, 2015 at 2:22 PM, Junio C Hamano [off-list ref] wrote:
Eric Sunshine [off-list ref] writes:
quoted
Moreover, it lacks justification and explanation of why you consider
the cleanup unnecessary. History [1] indicates that its application to
-F but not -t was intentional.

[1]: bc92377 (commit: fix ending newline for template files, 2015-05-26)
Sorry, but the date of that commit seems to be too new to be
considered "history"; I do not seem to have it, either.
Indeed, I somehow botched that. I meant: 8b1ae67 (Do not strip empty
lines / trailing spaces from a commit message template, 2011-05-08)
But I agree with you that I too failed to see why this change is
necessary or desirable in the explanation in the proposed log
message.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help