Stefan Beller [off-list ref] writes:
On Tue, May 26, 2015 at 3:21 PM, Junio C Hamano [off-list ref] wrote:
quoted
if (...->version < 2) {
... append "-%d" ...
}
involved.
Oh! I see here you would count the current one as 1, which has no
number extension, and any further would have a -${version}. That
would transport the intention much better I guess.
Yeah, except that I screwed up my comparison. Obviously, I should
have said "If version is 2 or later, then append -%d to the name,
otherwise use the name as-is".
On Tue, May 26, 2015 at 10:09:45PM -0700, Junio C Hamano wrote:
Stefan Beller [off-list ref] writes:
quoted
On Tue, May 26, 2015 at 3:21 PM, Junio C Hamano [off-list ref] wrote:
quoted
if (...->version < 2) {
... append "-%d" ...
}
involved.
Oh! I see here you would count the current one as 1, which has no
number extension, and any further would have a -${version}. That
would transport the intention much better I guess.
Yeah, except that I screwed up my comparison. Obviously, I should
have said "If version is 2 or later, then append -%d to the name,
otherwise use the name as-is".
FWIW, I had similar head-scratching over Stefan's original. I think it's
OK to say "version 1 is magical, and for historical reasons does not
have its number appended". There's no need for us ever to make
"upload-pack-1"; it just introduces more headaches.
-Peff